Make it possible to set timeout to health.NewPinger()#555
Merged
raphael merged 2 commits intogoadesign:mainfrom May 12, 2025
Merged
Make it possible to set timeout to health.NewPinger()#555raphael merged 2 commits intogoadesign:mainfrom
raphael merged 2 commits intogoadesign:mainfrom
Conversation
tchssk
force-pushed
the
health-pinger-option-timeout
branch
from
b12ea63 to
6555671
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 85.39% 85.55% +0.16%
==========================================
Files 39 39
Lines 2252 2257 +5
==========================================
+ Hits 1923 1931 +8
+ Misses 303 301 -2
+ Partials 26 25 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a configurable timeout in the NewPinger function, ensuring that health check requests can respect a timeout setting.
- Introduces a new WithTimeout option.
- Adds test cases to verify timeout behavior and updated options validation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| health/pinger_test.go | Updates tests with a timeout scenario and verifies the new timeout option. |
| health/pinger.go | Integrates timeout into the client structure and uses it when making HTTP requests. |
tchssk
force-pushed
the
health-pinger-option-timeout
branch
from
7726fab to
a801961
Compare
tchssk
force-pushed
the
health-pinger-option-timeout
branch
from
a801961 to
379eb11
Compare
Member
|
This is great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.